If the visitor visa is still valid but we have to change the passport, is the visa on the previous passport still valid?

A valid visa in an expired passport is still valid. So, when you travel to Canada, be sure to bring both the old passport with the visa and the new passport with you.